fix: safeFetch timer leak, env quote stripping, source count#84
Open
bloxi-bot wants to merge 1 commit intocalesthio:masterfrom
Open
fix: safeFetch timer leak, env quote stripping, source count#84bloxi-bot wants to merge 1 commit intocalesthio:masterfrom
bloxi-bot wants to merge 1 commit intocalesthio:masterfrom
Conversation
- Fix safeFetch() abort timer not cleared on error path (leaked per retry) - Strip surrounding quotes in .env parser (matches dotenv behavior) - Fix startup banner source count: 26 → 29 (matches actual briefing.mjs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit Fixes
Found these while doing a full code review of the repo. All low-risk, surgical changes.
Changes
1.
safeFetch()timer leak on error path (apis/utils/fetch.mjs)AbortControllertimeout timer was only cleared on the success path. Iffetch()throws (network error, DNS failure, etc.), the timer kept running until it fired — one leaked timer per retry attempt.controller/timercreation outsidetry, addedclearTimeout(timer)incatch.2.
.envparser doesn't strip quotes (apis/utils/env.mjs)FRED_API_KEY="abc123"orFRED_API_KEY='abc123'would include the surrounding quotes as part of the value, causing silent auth failures.3. Startup banner says 26 sources (server.mjs)
briefing.mjsactually runs 29runSource()calls. The README says 27. The banner said 26.Not Changed (noted for future)
Access-Control-Allow-Origin: *— fine for local use, but crucix.live should restrict it