Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move main.py into package and add vanity CLI #57

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cthoyt
Copy link

@cthoyt cthoyt commented Jan 17, 2021

Closes #56

This PR does the following:

  1. Moves main.py into the main package hierarchy. My personal preference is to name the file cli.py, but I'll leave this as an option to you
  2. Adds a vanity CLI using python entrypings (see changes in setup.py)
  3. Updates documentation in README.rst and jupyter notebook
  4. Bonus: add __main__.py for usage as python -m omop2obo as well as docs in the top explaining what's going on

Happy ontologizing!

@@ -80,4 +80,9 @@ def find_version(*file_paths):
'scikit-learn==0.23.2',
'tqdm==4.54.1'],
extras_require=extras,
entry_points={
"console_scripts": [
'omop2obo = omop2obo.main:main',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you change the name of the python file from main.py to cli.py, change this line like:

Suggested change
'omop2obo = omop2obo.main:main',
'omop2obo = omop2obo.cli:main',

@callahantiff
Copy link
Owner

@cthoyt - Thanks so much for doing this. I've got some big deadlines this week and will work on merging your changes this weekend.

@cthoyt
Copy link
Author

cthoyt commented Jan 19, 2021

@callahantiff no rush! good luck

@cthoyt
Copy link
Author

cthoyt commented Nov 9, 2021

Greetings from the future @callahantiff

congrats on the 1.0 release, I just updated the code vs the main branch and this could still be merged if you want

@callahantiff
Copy link
Owner

Thanks so much, @cthoyt!! - I am so sorry that I have not included the awesome work you did in release v1.0.0. I had to rush this release and it needed to follow a specific format for a downstream application. I am currently working on v2.0.0 and am planning on including the awesome change you made in that. I hope that's OK!

@cthoyt cthoyt mentioned this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vanity CLI
2 participants