Skip to content

fix: update JSX type for old React support #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update JSX type for old React support #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-mice-deliver.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@linaria/react': patch
---

Update types to support old React
22 changes: 5 additions & 17 deletions packages/react/src/styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,25 +107,13 @@ interface IProps {
style?: Record<string, string>;
}

// React <19
declare global {
// eslint-disable-next-line @typescript-eslint/no-namespace
namespace JSX {
interface IntrinsicElements {}
}
}

// React >=19
declare module 'react' {
// eslint-disable-next-line @typescript-eslint/no-namespace
namespace JSX {
interface IntrinsicElements {}
}
}

let idx = 0;

type IntrinsicElements = React.JSX.IntrinsicElements & JSX.IntrinsicElements;
interface IntrinsicElements
// in newer react types JSX is moved under React namespace
// @ts-expect-error ts 2694
extends React.JSX.IntrinsicElements,
JSX.IntrinsicElements {}

// Components with props are not allowed
function styled(
Expand Down