Skip to content

Conversation

nickhudkins
Copy link

😳 It appears that tests have not been running in CI for this project. This does reveal broken tests, which I will address in a follow up commit. For now, opening for visibility, and if someone else wants to pick up fixing the tests, by all means I welcome the help!

Motivation

When using postcss-linaria as a customSyntax for stylelint, certain forms of JS interpolations are improperly transformed.

Example:

// Before Fix

const SOME_INTERPOLATION = '--wow-neat-property-bro';
const myStyles = css`.foo {
  color: var(${SOME_INTERPOLATION});
}`


// After StyleLint Auto-Fix:
const SOME_INTERPOLATION = '--wow-neat-property-bro';
const myStyles = css`.foo {
  color: var(/* ${SOME_INTERPOLATION}:0 */);
}`

Summary

In the current form of the PR, only "running the tests in CI" has been addressed.

Test plan

CI! We're gonna run the tests that test the code, on every PR. It'll be great.

😳 It appears that tests have not been running in CI for this project. This *does* reveal broken tests, which I will address in a follow up commit. For now, opening for visibility, and if someone else wants to pick up fixing the tests, by all means I welcome the help!
Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: 305dc31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants