-
Notifications
You must be signed in to change notification settings - Fork 28
feat: add method to deallocate reactNativeFactory instance for iOS #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
californiandreamer
wants to merge
3
commits into
callstack:main
Choose a base branch
from
californiandreamer:feat/add-deallocate-method-ios
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−25
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,12 +69,18 @@ class ReactNativeBrownfieldDelegate: RCTDefaultReactNativeFactoryDelegate { | |
| * Default value: nil | ||
| */ | ||
| private var reactNativeFactory: RCTReactNativeFactory? = nil | ||
| /** | ||
| * Root view factory used to create React Native views. | ||
| */ | ||
| lazy private var rootViewFactory: RCTRootViewFactory? = { | ||
| return reactNativeFactory?.rootViewFactory | ||
| }() | ||
| private var hasStartedReactNative = false | ||
|
|
||
| private var factory: RCTReactNativeFactory { | ||
| if let existingFactory = reactNativeFactory { | ||
| return existingFactory | ||
| } | ||
|
|
||
| delegate.dependencyProvider = RCTAppDependencyProvider() | ||
| let createdFactory = RCTReactNativeFactory(delegate: delegate) | ||
| reactNativeFactory = createdFactory | ||
| return createdFactory | ||
| } | ||
|
|
||
| /** | ||
| * Starts React Native with default parameters. | ||
|
|
@@ -88,7 +94,11 @@ class ReactNativeBrownfieldDelegate: RCTDefaultReactNativeFactoryDelegate { | |
| initialProps: [AnyHashable: Any]?, | ||
| launchOptions: [AnyHashable: Any]? = nil | ||
| ) -> UIView? { | ||
| reactNativeFactory?.rootViewFactory.view( | ||
| let resolvedFactory = factory | ||
|
|
||
| let rootViewFactory = resolvedFactory.rootViewFactory | ||
|
|
||
| return rootViewFactory.view( | ||
| withModuleName: moduleName, | ||
| initialProperties: initialProps, | ||
| launchOptions: launchOptions | ||
|
|
@@ -111,29 +121,54 @@ class ReactNativeBrownfieldDelegate: RCTDefaultReactNativeFactoryDelegate { | |
| * @param launchOptions Launch options, typically passed from AppDelegate. | ||
| */ | ||
| @objc public func startReactNative(onBundleLoaded: (() -> Void)?, launchOptions: [AnyHashable: Any]?) { | ||
| guard reactNativeFactory == nil else { return } | ||
|
|
||
| delegate.dependencyProvider = RCTAppDependencyProvider() | ||
| self.reactNativeFactory = RCTReactNativeFactory(delegate: delegate) | ||
| guard !hasStartedReactNative else { return } | ||
| _ = launchOptions | ||
| _ = factory | ||
|
|
||
| if let onBundleLoaded { | ||
| self.onBundleLoaded = onBundleLoaded | ||
| if RCTIsNewArchEnabled() { | ||
| NotificationCenter.default.addObserver( | ||
| self, | ||
| selector: #selector(jsLoaded), | ||
| name: NSNotification.Name("RCTInstanceDidLoadBundle"), | ||
| object: nil | ||
| ) | ||
| } else { | ||
| NotificationCenter.default.addObserver( | ||
| self, | ||
| selector: #selector(jsLoaded), | ||
| name: NSNotification.Name("RCTJavaScriptDidLoadNotification"), | ||
| object: nil | ||
| ) | ||
| let notificationName: Notification.Name = RCTIsNewArchEnabled() | ||
| ? Notification.Name("RCTInstanceDidLoadBundle") | ||
| : Notification.Name("RCTJavaScriptDidLoadNotification") | ||
|
|
||
| NotificationCenter.default.addObserver( | ||
| self, | ||
| selector: #selector(jsLoaded), | ||
| name: notificationName, | ||
| object: nil | ||
| ) | ||
|
|
||
| if let bridge = reactNativeFactory?.bridge, !bridge.isLoading { | ||
| DispatchQueue.main.async { [weak self] in | ||
| self?.jsLoaded(Notification(name: notificationName)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| hasStartedReactNative = true | ||
| } | ||
|
|
||
| /** | ||
| * Stops React Native and releases the underlying factory instance. | ||
| */ | ||
| @objc public func stopReactNative() { | ||
| if !Thread.isMainThread { | ||
| DispatchQueue.main.async { [weak self] in self?.stopReactNative() } | ||
| return | ||
| } | ||
|
|
||
| guard let factory = reactNativeFactory else { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: |
||
| hasStartedReactNative = false | ||
| return | ||
| } | ||
|
|
||
| factory.bridge?.invalidate() | ||
|
|
||
| NotificationCenter.default.removeObserver(self) | ||
| onBundleLoaded = nil | ||
|
|
||
| hasStartedReactNative = false | ||
| reactNativeFactory = nil | ||
| } | ||
|
|
||
| @objc private func jsLoaded(_ notification: Notification) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changing the previous behavior. jsLoaded should be called by React Native sending this notification