- 
                Notifications
    
You must be signed in to change notification settings  - Fork 221
 
feat: add support for expo example in native libraries #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bc5f10b    to
    aaba90f      
    Compare
  
    a063eb6    to
    5d0ae8b      
    Compare
  
    | 
           Would this allow two parallel examples? React Native and Expo in parallel? While we use Builder Bob, we ditched the example. Instead we have monorepo setup to have a React Native and Expo example app in parallel, to validate both flavors work. https://github.com/maplibre/maplibre-react-native/tree/807db0e22593cc48fc316dcd9e91c27b1e6186a3/packages We also included the plugin into the Builder Bob build, which might be interesting to others, who have to distribute a expo plugin to make their library work? See maplibre/maplibre-react-native#576.  | 
    
| 
           @KiwiKilian the CLI will only generate a single example of the chosen type, but you can always copy the example folder to a new folder to have 2 examples.  | 
    
| 
           Only problem with this approach is the code sharing between both examples. But I do understand, that you won't to support this from the CLI creation, as it's rather complex.  | 
    
c710468    to
    9707e7a      
    Compare
  
    9707e7a    to
    dd9775f      
    Compare
  
    9ca6093    to
    72a579c      
    Compare
  
    0b45375    to
    7799977      
    Compare
  
    | }, | ||
| }), | ||
| <% } else { -%> | ||
| <% } else if (example === 'vanila') { -%> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <% } else if (example === 'vanila') { -%> | |
| <% } else if (example === 'vanilla') { -%> | 
This doesn't work yet since Expo doesn't support
react-native.config.jsfor linking the module. We need to figure out another option.Edit: actually seems like it's because there's a bug in Expo's autolinking mechanism. PR here expo/expo#33532