Skip to content

fix(web): align step markers with thumb position using thumbSize prop #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mikolajwilczek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): align step markers with thumb position using thumbSize prop #751

mikolajwilczek wants to merge 1 commit into from
+57 −8

Conversation

@mikolajwilczek
Copy link

@mikolajwilczek mikolajwilczek commented Dec 18, 2025

Fixes #743

Summary:

  • Fix step marker alignment on web platform edges
  • Pass thumbSize prop to StepsIndicator component
  • Use actual thumbSize value instead of hardcoded constant
  • Add WebProps type for proper TypeScript typing

Test Plan:

  • Verified the change only affects the web platform - native platforms (iOS/Android) remain unchanged
  • Added web example with step numbers to demonstrate the fix
  • Tested step marker alignment at left edge, center, and right edge positions - all markers now align correctly with thumb positions
  • Tested with default and custom thumbSize values on web - alignment works correctly when thumbSize is smaller than the gap between steps
  • Regression tested on iOS, Android, and web (Safari and Chrome) - all existing examples continue to work
Screenshot 2025-12-18 at 20 12 13

@mikolajwilczek
fix(web): align step markers with thumb position using thumbSize prop
d7eb359 
- Pass thumbSize prop to StepsIndicator component
- Use actual thumbSize value instead of hardcoded constant
- Add WebProps type for proper TypeScript typing
- Fix step marker alignment on web platform edges

Fixes callstack#743
@mikolajwilczek mikolajwilczek mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web: Step markers don't align with thumb positions

1 participant

@mikolajwilczek