-
Notifications
You must be signed in to change notification settings - Fork 5
Support AAB #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support AAB #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Artifact cache doesn't distinguish AAB from APK
The ARTIFACT_TRAITS used for caching only includes variant and optionally PR number, but doesn't include the aab input. This causes the system to return a cached APK when an AAB is requested (or vice versa) if they share the same variant, since the artifact lookup can't distinguish between the two build types.
action.yml#L139-L141
Lines 139 to 141 in c80cb68
| run: | | |
| ARTIFACT_TRAITS="${{ inputs.variant }},${{ github.event.pull_request.number}}" | |
| echo "ARTIFACT_TRAITS=$ARTIFACT_TRAITS" >> $GITHUB_ENV |
action.yml#L153-L155
Lines 153 to 155 in c80cb68
| run: | | |
| ARTIFACT_TRAITS="${{ inputs.variant }}" | |
| echo "ARTIFACT_TRAITS=$ARTIFACT_TRAITS" >> $GITHUB_ENV |
action.yml#L283-L284
Lines 283 to 284 in c80cb68
| fi | |
| ARTIFACT_TRAITS="${{ inputs.variant }},${IDENTIFIER}" |
|
Thanks for the contribution! Removing |
This reverts commit 0ac4854.
|
@thymikee can we merge please? |
| if: ${{ github.event_name == 'pull_request' && inputs.re-sign == 'true' }} | ||
| run: | | ||
| ARTIFACT_TRAITS="${{ inputs.variant }},${{ github.event.pull_request.number}}" | ||
| ARTIFACT_TRAITS="${{ inputs.variant }},${{ env.BUILD_TYPE }},${{ github.event.pull_request.number}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will break existing remote caching. Let's remove that and for now you'll need to differentiate another way between APK and AAB artifacts (e.g. by setting up an env variable and adding that to fingerprint config: https://www.rockjs.dev/docs/configuration#fingerprint-configuration)
| if: ${{ !env.ARTIFACT_NAME }} | ||
| run: | | ||
| ARTIFACT_TRAITS="${{ inputs.variant }}" | ||
| ARTIFACT_TRAITS="${{ inputs.variant }},${{ env.BUILD_TYPE }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
| APK_PATH=$(find $ANDROID_SOURCE_DIR/$APP_NAME/build/outputs -name '*.apk' | head -1 ) | ||
| echo APK_PATH $APK_PATH | ||
| echo "ARTIFACT_PATH=$APK_PATH" >> $GITHUB_ENV | ||
| BINARY_PATH=$(find $ANDROID_SOURCE_DIR/$APP_NAME/build/outputs -name '*.${{ inputs.aab == 'true' && 'aab' || 'apk' }}' | head -1 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's create BINARY_EXT variable and use that instead of ${{ inputs.aab == 'true' && 'aab' || 'apk' }}
Note
Add AAB build support and propagate build type through artifact discovery, caching, naming, and messaging.
action.yml):aabinput to toggle Android App Bundle builds.BUILD_TYPEenv (aab/apk) and pass--aabtorock build:androidwhen enabled.*.aabor*.apkaccordingly.README.md):aabusage and input in examples and Inputs table.Written by Cursor Bugbot for commit b680fac. This will update automatically on new commits. Configure here.