-
Notifications
You must be signed in to change notification settings - Fork 4
Handle Info.plist lookup in versioned frameworks #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely beautiful! 💙 Thanks for lot for iterating on this 👍
The only thing I'm missing (not a blocker for merging, but it could be nice) are tests to ensure this doesn't regress 🙏
I've also added the "Apple" label to make the iOS test app run on any new commits to this branch.
Added tests! |
About
This PR fixes the following error I encountered when autolinking a framework built for macOS (which I brought up on Discord):
The error indicates that it was unable to find
Info.plist
at the root of the framework. Indeed, it should have been looking elsewhere.Details
iOS frameworks conventionally have this "unversioned" structure, where the
Info.plist
is placed at the root of the framework:macOS frameworks conventionally have a "versioned" structure, where the
Info.plist
is instead nested atVersions/Current/Info.plist
:This PR first checks for an
Info.plist
at the root, then falls back to checking at the nested path.