Revert visionOS changes and provide Copilot instruction improvements #289
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Check visionOS | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test-visionos: | ||
| name: Test Ferric with visionOS Triplets | ||
| runs-on: macos-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/iron | ||
| # Install visionOS targets for Rust | ||
| - run: rustup target add aarch64-apple-visionos aarch64-apple-visionos-sim | ||
| # Also install required iOS targets for the bootstrap process | ||
| - run: rustup target add aarch64-apple-ios-sim | ||
| - run: npm ci | ||
| - run: npm run build | ||
| # Bootstrap host package to get weak-node-api and ferric-example with visionOS support | ||
| - run: npm run bootstrap --workspace react-native-node-api | ||
| - run: npm run bootstrap --workspace @react-native-node-api/ferric-example | ||
| env: | ||
| CMAKE_RN_TRIPLETS: aarch64-apple-visionos,aarch64-apple-visionos-sim | ||
| FERRIC_TARGETS: aarch64-apple-visionos,aarch64-apple-visionos-sim | ||
| - run: npm run lint | ||
|
||
| env: | ||
| DEBUG: eslint:eslint | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work. These targets are tier 3 and won't be available prebuilt, so you need to build / bootstrap the Rust compiler as I mentioned in the instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to bootstrap the Rust compiler from source instead of using rustup target add. The workflow now clones rust-lang/rust, configures build for visionOS targets, and uses ./x.py build and install commands. Commit 8f8d49d