Skip to content

Moved patching of JSI headers to a separate function #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
Merged

Moved patching of JSI headers to a separate function #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 31 additions & 18 deletions packages/host/src/node/cli/hermes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,32 @@ const platformOption = new Option(
"The React Native package to vendor Hermes into",
).default("react-native");

type PatchJSIHeadersOptions = {
reactNativePath: string;
hermesJsiPath: string;
silent: boolean;
};

async function patchJsiHeaders({
reactNativePath,
hermesJsiPath,
silent,
}: PatchJSIHeadersOptions) {
const reactNativeJsiPath = path.join(reactNativePath, "ReactCommon/jsi/jsi/");
await oraPromise(
fs.promises.cp(hermesJsiPath, reactNativeJsiPath, {
recursive: true,
}),
{
text: `Copying JSI from patched Hermes to React Native`,
successText: "Copied JSI from patched Hermes to React Native",
failText: (err) =>
`Failed to copy JSI from Hermes to React Native: ${err.message}`,
isEnabled: !silent,
},
);
}

export const command = new Command("vendor-hermes")
.argument("[from]", "Path to a file inside the app package", process.cwd())
.option("--silent", "Don't print anything except the final path", false)
Expand Down Expand Up @@ -64,11 +90,6 @@ export const command = new Command("vendor-hermes")
console.log(`Using Hermes version: ${hermesVersion}`);
}

const reactNativeJsiPath = path.join(
reactNativePath,
"ReactCommon/jsi/jsi/",
);

const hermesPath = path.join(reactNativePath, "sdks", "node-api-hermes");
if (force && fs.existsSync(hermesPath)) {
await oraPromise(
Expand Down Expand Up @@ -125,19 +146,11 @@ export const command = new Command("vendor-hermes")
fs.existsSync(hermesJsiPath),
`Hermes JSI path does not exist: ${hermesJsiPath}`,
);

await oraPromise(
fs.promises.cp(hermesJsiPath, reactNativeJsiPath, {
recursive: true,
}),
{
text: `Copying JSI from patched Hermes to React Native`,
successText: "Copied JSI from patched Hermes to React Native",
failText: (err) =>
`Failed to copy JSI from Hermes to React Native: ${err.message}`,
isEnabled: !silent,
},
);
await patchJsiHeaders({
reactNativePath,
hermesJsiPath,
silent,
});
console.log(hermesPath);
}),
);
Loading