Skip to content

Commit

Permalink
Fixed assertion of ap_done (#1076)
Browse files Browse the repository at this point in the history
ap_done is now not asserted based on timeouts, rather only on memories_sent
being asserted. Avoids confusing behavior where hardware seems to abort
without a reason.

At some point we may want to revert this to enable
timeouts?

Co-authored-by: Nathaniel Navarro <[email protected]>
  • Loading branch information
nathanielnrn and nathanielnrn authored Jul 6, 2022
1 parent a155ae9 commit 45f0dd5
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions src/backend/xilinx/toplevel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -245,13 +245,7 @@ fn top_level(
// done signal
module.add_stmt(v::Parallel::Assign(
"ap_done".into(),
v::Expr::new_logical_or(
v::Expr::new_gt("counter", "timeout"),
v::Expr::new_eq(
"memories_sent",
v::Expr::new_ulit_bin(memories.len() as u32, "1"),
),
),
"memories_sent".into(),
));

module
Expand Down

0 comments on commit 45f0dd5

Please sign in to comment.