Fix concatenation on WDATA and WSTRB #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously WSTRB assumed all sent bytes were valdid, with these changes only the first 4 bytes are valid (sent as 32 bit int). Might want to revert these changes at some point. Previoulsy WDATA repeated the data of bram_read_data across it's width. Now, only the end of the channel contains bram_read_data's values.
12 tasks
|
LGTM! For a future PR, I think we should break up that function because it is crazy big! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously WSTRB assumed all sent bytes were valdid, with these changes
only the first 4 bytes are valid (sent as 32 bit int). Might want
to revert these changes at some point.
Previoulsy WDATA repeated the data of bram_read_data across it's width.
Now, only the end of the channel contains bram_read_data's values.
Ticks 2 boxes on #1072 and tied to #1022