Massage away 2-way PIFOs #2234
Merged
Massage away 2-way PIFOs #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanmohan
requested changes
Aug 6, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes progress towards #2226 by updating variable names and comments to account for the fact that round robin PIFOs can make n-way trees. Additionally, it implements a PIFO tree and a more complicated tree (
complicated_tree.py) using round robin and strict queues. This accounts for the first three checkboxes of #2226. The docs have been updated to reflect the new PIFO style in #2223. To run the relevant tests,(For sdn.py, I removed the stats component stuff because I thought it was mentioned that this wasn't important and so the new style PIFOs are not equipped to do stats. If it needs to be there, let me know.)