[fud2] Experimental support for managing python environment #2265
Conversation
|
Realized I didn't need the dynamic subcommands. Normal subcommands sort of work. There is the downside though that if some user of |
this relieves the burden of implementing `argh::DynamicSubCommand` from the user of `fud_core`. Now a user can simply forward the parsing implementations for standard `argh::SubCommand`s to extend the fud cli.
|
This pull request has not seen activity in 14 days and is being marked as stale. If you're continuing work on this, please reply and state how to get this PR in a mergeable state or what issues it is blocked on. If the PR is not ready for review, please mark it as a draft. The PR will be closed in 7 days if there is no further activity. |
|
Just waiting on a review for this |
|
Does the help screen not show the new 'env' command? |
|
It shows up for me: |
|
For more context. The implementation has diverged from the original. I'm just using normal argh::Subcommands instead of the |
|
That seems fine to me! Can you add some documentation about how this command works for docs.calyxir.org? Apart from that, LGTM! |
This removes the distinction between `cli` and `cli_ext` methods to simplify the experinece for a user of `fud_core`. Naming of structures also makes it clear that the cli can be extended.
|
Added the docs, and slightly simplified the Cli Extention API, which also had the effect of not having the empty command appear if you're not using a Cli extension. Once I get the ok, I'll click the green button. |
|
LGTM! |
This is an experiment and I'm curious what folks think.
The main thing this PR does is to add an
envsubcommand thatfud2.tomlto point to the virtualenv pythonThe point of this is to simplify the user experience of getting fud2 up and running and eases the burden of having to manually deal with installing python packages into the right place (see #2263). However, I'm not sure if we want
fud2to be in the business of managing python dependencies. The right place to solve this might actually be in documentation.This feels very fud2 specific and so I've put this in the fud2 frontend rather than in
fud-core. To accomplish this I implemented a method for extending the cli thatfud-coreprovides. This takes advantage ofargh::DynamicSubCommand. This works, but has the downside of not updating the--helpscreen. I might just be doing something wrong there, who knows.