Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cider2] use baa as bit-vector library #2281

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Sep 11, 2024

This replaces the homespun bit-vector library in Cider with baa from crates.io.

@ekiwi ekiwi marked this pull request as ready for review September 12, 2024 14:23
Copy link
Collaborator

@EclecticGriffin EclecticGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Very excited to see how this impacts the overall performance. I cleaned up the merge conflict I introduced with my last PR, so this should be good to go.

@EclecticGriffin EclecticGriffin enabled auto-merge (squash) September 16, 2024 18:19
#
# It is recommended to check this file in to source control so that
# everyone who runs the test benefits from these saved cases.
cc 8bfbc0242b84cd41283ecc9c000e88751215cf3bbef619b67f08dcb64f8ab602 # shrinks to input = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What uses this input file?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo test

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the regression seeds for the proptest tests

@EclecticGriffin EclecticGriffin merged commit d195989 into calyxir:main Sep 16, 2024
9 checks passed
EclecticGriffin added a commit that referenced this pull request Sep 16, 2024
Corrects a regression introduced in #2281. Adds some better error
reporting for the data dumps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants