Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jq stage to fud2 #2333

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Add jq stage to fud2 #2333

merged 5 commits into from
Nov 5, 2024

Conversation

rachitnigam
Copy link
Contributor

@rachitnigam rachitnigam commented Nov 5, 2024

Adding jq stage to fud2 but I've been having trouble getting the stage to print out the value from the command. It seems like the jq ... > $out call gobbles up the output. Not sure if I'm making a mistake.

Any thoughts @EclecticGriffin @ekiwi or @sampsyo?

@EclecticGriffin
Copy link
Collaborator

Seems to be working for me? I was able to run

 fud2 --from calyx --to jq --through cider -s sim.data=benchmarks/ntt-32.futil.data -s calyx.args="--log off" benchmarks/ntt-32.futil -s jq.expr="." -s jq.flags="--sort-keys"

and got mostly the expected result, minus a missing newline at the very end.

Feels like we could use jq.expr as "." by default but don't think that's strictly required

@rachitnigam
Copy link
Contributor Author

Huh, I don't seem to get any output when using it for some reason but if you say it works, I'll transition the tests to use it!

@rachitnigam rachitnigam marked this pull request as ready for review November 5, 2024 19:53
Copy link
Collaborator

@EclecticGriffin EclecticGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming CI is happy!

@rachitnigam rachitnigam merged commit 6b48969 into main Nov 5, 2024
18 checks passed
@rachitnigam rachitnigam deleted the fud2-jq-state branch November 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants