Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MulRound, MulLower and MulAddLower ops #10

Open
wants to merge 85 commits into
base: master
Choose a base branch
from
Open

MulRound, MulLower and MulAddLower ops #10

wants to merge 85 commits into from

Conversation

mazimkhan
Copy link
Member

@mazimkhan mazimkhan commented Nov 18, 2024 •
edited
Loading

Adding special multiply operations for arm_sve-inl.h and generic_ops-inl.h:

  • MulRound multiplies two vectors of floats and returns the answer rounded to the nearest integer
  • MulLower multiplies the first lane of both input vectors and passes the lanes of vector a for all other lanes.
  • MulAddLower performs a multiply-accumulate operation on the first lane of the input vectors and passes the lanes of vector a for all other lanes.

Tests have been added for the operations.

malaterre and others added 30 commits May 30, 2024 13:57
@malaterre
Allow compilation of AVX2 on x86
216a960
@johnplatts
Added MinMagnitude and MaxMagnitude ops
620fec7
@lsrcz
add Get/Set for vectors and use them to implement Concat* operators
57a6c9b
@dependabot
Bump step-security/harden-runner from 2.10.1 to 2.10.2
bea0da5 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.1 to 2.10.2.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@91182cc...0080882)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@copybara-github
Merge pull request google#2381 from google:dependabot/github_actions/…
5c7a693 
…step-security/harden-runner-2.10.2

PiperOrigin-RevId: 697981775
@Mousius
Revert to previous logic for GatherIndexN
3da3328
@jan-wassenberg @copybara-github
detect cache parameters
3cb3a91 
PiperOrigin-RevId: 698357330
@jan-wassenberg @copybara-github
replace non-test/trace fprintf with new hwy::Warn/HWY_WARN
8a0602d 
PiperOrigin-RevId: 698416280
@jan-wassenberg @copybara-github
topology fixes for M3
89b2678 
PiperOrigin-RevId: 698685120
@jan-wassenberg @copybara-github
Add topology support for Windows and Apple
d22ccd0 
Also reduce #if in mainline by factoring into helper functions, share code between Linux and FreeBSD
Use anon namespace instead of static

PiperOrigin-RevId: 699906189
@jan-wassenberg @copybara-github
add LSX/LASX targets. Refs google#2386
7e01a07 
PiperOrigin-RevId: 699936076
@copybara-github
Merge pull request google#2383 from Mousius:revert-gatherindexn
2b565e8 
PiperOrigin-RevId: 699943134
@ZequanWu @copybara-github
Remove VQSORT_SKIP workaround for compiler bug
02253c8 
The test passes with the most recent clang.

PiperOrigin-RevId: 700385250
@jan-wassenberg @copybara-github
Add BitsFromMask, promoting from detail::.
68b0fde 
Also split mask_test into mask_set_test,
remove unused overload in scalar,
modernize overloads (SFINAE instead of type tags).

PiperOrigin-RevId: 700701299
@jan-wassenberg @copybara-github
Add BitsFromMask, promoting from detail::.
bcf564e 
Also split mask_test into mask_set_test,
remove unused overload in scalar,
modernize overloads (SFINAE instead of type tags).

PiperOrigin-RevId: 700938851
@johnplatts
Added AVX10_2 and AVX10_2_512 targets
9b39ef2
@copybara-github
Merge pull request google#2395 from johnplatts:hwy_avx10_120124
b13a46f 
PiperOrigin-RevId: 701876987
@jan-wassenberg @copybara-github
(v2 of) Add BitsFromMask, promoting from detail::.
62c0a79 
Provide DFromM on all targets except SVE/RVV.
Also split mask_test into mask_set_test,
remove unused overload in scalar,
modernize overloads (SFINAE instead of type tags).
arm_sve required moving some sections earlier before their first usage.

PiperOrigin-RevId: 701919058
@johnplatts
Fix for RVV CMake detection if cross-compiling with Clang
07396f9
@johnplatts
Made changes to RVV Concat, Combine, ZeroExtendVector, and UpperHalf ops
914cb69
@copybara-github
Merge pull request google#2396 from johnplatts:hwy_rvv_cmake_fix_120224
9689e2c 
PiperOrigin-RevId: 702035129
@johnplatts
Enable tuples on RVV with Clang 17 or later
80839b5
@copybara-github
Merge pull request google#2397 from johnplatts:hwy_rvv_tuple_120224
fca5363 
PiperOrigin-RevId: 702229080
@dependabot
Bump actions/cache from 4.0.2 to 4.2.0
fccc82d 
Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.2.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0c45773...1bd1e32)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@copybara-github
Merge pull request google#2401 from google:dependabot/github_actions/…
b9fa960 
…actions/cache-4.2.0

PiperOrigin-RevId: 703468488
@jan-wassenberg @copybara-github
add perf_counters
83b81ab 
PiperOrigin-RevId: 705134221
@jan-wassenberg @copybara-github
fix topology detection for some CPUs being offline (e.g. SMT off)
a076ade 
PiperOrigin-RevId: 705569288
@johnplatts
Fixes for ZSeries with GCC 9 or earlier or Clang 18 or earlier
eb4dc59
@copybara-github
Merge pull request google#2411 from johnplatts:jep_s390x_fix_121324
065050e 
PiperOrigin-RevId: 706272646
@jan-wassenberg @copybara-github
update thresholds for test failure
49674e1 
PiperOrigin-RevId: 706764322
Highway and others added 29 commits January 17, 2025 07:35
@copybara-github
hwy-contrib/thread_pool: Replace size check assert with skip.
fdf177d 
PiperOrigin-RevId: 716663095
@jan-wassenberg @copybara-github
add HWY_UNREACHABLE and add documentation for related macros
a811732 
PiperOrigin-RevId: 716696598
@johnplatts
Fix for GCC 15 compiler error on PPC8/PPC9/PPC10
dcc0ca1
@johnplatts
Added PositiveInfOrHighestValue and NegativeInfOrLowestValue
070bc1f
@johnplatts
Fix for compiler error with GCC 9 or earlier
758ec70
@copybara-github
Merge pull request google#2447 from johnplatts:hwy_gcc9_fix_011725
a372d95 
PiperOrigin-RevId: 717451768
@dependabot
Bump step-security/harden-runner from 2.10.3 to 2.10.4
cf6a122 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.3 to 2.10.4.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@c95a14d...cb605e5)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@copybara-github
Merge pull request google#2445 from johnplatts:hwy_ppc_gcc15_fix_011725
6c6b289 
PiperOrigin-RevId: 717506931
@copybara-github
Merge pull request google#2448 from google:dependabot/github_actions/…
f2209b9 
…step-security/harden-runner-2.10.4

PiperOrigin-RevId: 717528316
@jan-wassenberg @copybara-github
warning fix (unused param)
fc384ee 
PiperOrigin-RevId: 717590393
@scuzqy @copybara-github
Copybara import of the project:
21a6bb0 
--
fa07d18 by scuzqy <[email protected]>:

Resolve TODO in aligned_allocator

And updated corresponding test.
AllocateAligned was designed to take POD types only.

COPYBARA_INTEGRATE_REVIEW=google#2298 from scuzqy:AlignedAllocatorPOD fa07d18
PiperOrigin-RevId: 717822922
@johnplatts
Merge branch 'master' into hwy_reduce_enh_011725
aec1978
@copybara-github
Merge pull request google#2446 from johnplatts:hwy_reduce_enh_011725
b5dd1c4 
PiperOrigin-RevId: 718362378
@jan-wassenberg @copybara-github
fix incompatibility with Windows macro, fixes google#2450, thanks @sc…
0b69663 
…uzqy

PiperOrigin-RevId: 718419557
@jan-wassenberg @copybara-github
no longer require opt-in for AVX3_DL
9c8e963 
PiperOrigin-RevId: 720535765
@copybara-github
no longer require opt-in for AVX3_DL
960f74d 
PiperOrigin-RevId: 720561925
@mazimkhan @wbb-ccl
Promote and round operations
9e30869
@mazimkhan @wbb-ccl
Add quick reference for MaskedConvertToOrZero
ade9ee9
@mazimkhan @wbb-ccl
MaskedConvertToOrZero implementation for Arm SVE
5c9c45b
@wbb-ccl
Fix review comments
7d9079b 
Remove OrZero suffixes for consistency
Drop duplication of generic implementation
@mazimkhan @wbb-ccl
Float operations SqrtLower, MulSubAdd, GetExponent etc.
bb045cc
@wbb-ccl
Fix review comments
e3c6c3b 
Remove OrZero suffixes for consistency
Convert SqrtLower into MaskedSqrtOr
Add TODO comments about GetExponent to x86_512 and ppc_vsx
@wbb-ccl
Remove new ops that only have a generic implementation
83f183d
@copybara-github
Merge pull request google#2425 from cambridgeconsultants:cc_up_float_…
d547f91 
…operations

PiperOrigin-RevId: 720600683
@wbb-ccl
Fix bool_lanes typing
acd4f09
@copybara-github
Merge pull request google#2424 from cambridgeconsultants:cc_up_conver…
9cb44bc 
…t_promote_demote

PiperOrigin-RevId: 720897646
@mazimkhan @wbb-ccl
MulRound, MulLower and MulAddLower ops
cdd64d2
@wbb-ccl
Fix review comments
c264695 
Remove MulLower
Use MaskedMulOr instead
Replace MulAddLower with MaskedMulAddOr
@wbb-ccl
Remove redundant macro
ec5b0aa
@wbb-ccl wbb-ccl force-pushed the cc_up_mul_and_arithmetic branch from 11505cf to ec5b0aa Compare January 29, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.