Support arbitrary cgi-data metadata

README.md

@@ -59,6 +59,8 @@ all possible metadata values:
 (hb/notify hb-config
            (Exception. "Vapor Lock")
            {:tags [:serious :business]
+            :cgi-data {"SERVER_NAME" "crywolf.dev"
+                       "SERVER_PORT" "80"}
             :component "robot-brain" ; ~= a Rails controller
             :action "think"          ; ~= a Rails action
             :context {:name "Winston"

src/honeybadger/core.clj

@@ -67,19 +67,18 @@
 (defn- error-patch [notifiable]
   {:error (error-map notifiable)})
 
-(defn- metadata-patch [{:keys [tags context component action request]}]
-  (let [{:keys [method url params session]} request]
+(defn- metadata-patch [{:keys [tags cgi-data component context action request]}]
+  (let [{:keys [method url params session]} request
+        cgi-data' (cond-> cgi-data
+                    method (assoc "REQUEST_METHOD" (str/upper-case (name method))))]
     {:error   {:tags tags}
      :request {:url url
                :component component
                :action action
                :params params
                :context (or context {})  ; diplays differently if nil
                :session session
-               :cgi-data (some->> method
-                                  name
-                                  str/upper-case
-                                  (array-map "REQUEST_METHOD"))}}))
+               :cgi-data cgi-data'}}))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
@@ -109,7 +108,8 @@
       (update-contained-in [:metadata :request :method] keyword)
       (update-contained-in [:metadata :request :params]  #(or % {}))
       (update-contained-in [:metadata :request :session] #(or % {}))
-      (->> (deep-merge {:metadata {:tags #{}
+      (->> (deep-merge {:metadata {:cgi-data {}
+                                   :tags #{}
                                    :request {}
                                    :context {}
                                    :component nil

src/honeybadger/schemas.clj

@@ -11,6 +11,7 @@
                            (s/optional-key :url)     s/Str
                            (s/optional-key :params)  {s/Keyword s/Any}
                            (s/optional-key :session) {s/Keyword s/Any}}
+               :cgi-data  {s/Keyword s/Any}
                :context   {s/Keyword s/Any}
                :component (s/maybe s/Str)
                :action    (s/maybe s/Str)}})

test/honeybadger/core_test.clj

@@ -0,0 +1,19 @@
+(ns honeybadger.core-test
+  (:require [clojure.test :refer :all]
+            [honeybadger.core :as hb]))
+
+(defn- format-metadata [metadata]
+  (-> (#'hb/event->notice
+       (#'hb/normalize-event "123"
+                             "development"
+                             "test"
+                             metadata))
+      :request
+      :cgi-data))
+
+(deftest cgi-data
+  (are [out in] (= out (format-metadata in))
+    {}                                   {}
+    {:foo "bar"}                         {:cgi-data {"foo" "bar"}}
+    {"REQUEST_METHOD" "GET"}             {:request {:method :get}}
+    {"REQUEST_METHOD" "GET", :foo "bar"} {:request {:method :get} :cgi-data {"foo" "bar"}}))