fix: make ExponentialBackoff concurrency-safe#60
Open
fazilnbr wants to merge 1 commit into
Open
Conversation
- Guard shared random source with a mutex to prevent concurrent access - Fix race condition in defaultBackoffSupplier during retry delay generation - Prevent "index out of range" panics when multiple job pollers call SupplyRetryDelay simultaneously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data race in ExponentialBackoff supplier causes "index out of range" panic under concurrent polling
Description
ExponentialBackoffuses a shared package-leveldefaultBackoffSupplier, which contains a single*rand.Randinstance. Sincemath/rand.Randis not concurrency-safe, concurrent calls toSupplyRetryDelay()can corrupt the RNG state and cause panics such as:This change makes the shared supplier concurrency-safe by protecting access to the random source with a mutex.
Changes
ExponentialBackoffe.random.Float64()incomputeJitterTesting
SupplyRetryDelay()from multiple goroutines against a shared suppliergo test -race ./pkg/worker/...Fixes
Fixes #<ISSUE_NUMBER>
Type of Change
Checklist