Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authorization): add bearer token authorization #275

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

nithinssabu
Copy link
Contributor

@nithinssabu nithinssabu commented Nov 6, 2024

Description of the change

Closes #276

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have opened this pull request against the alpha branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

[If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...]

@jwulf
Copy link
Member

jwulf commented Nov 7, 2024

Hi @nithinssabu , thanks for the contribution.

Can you give me an idea of the use case for this?

@nithinssabu
Copy link
Contributor Author

Hi @nithinssabu , thanks for the contribution.

Can you give me an idea of the use case for this?

Hey @jwulf

This is required as part of a change in the deployment functionality within Web Modeler. The epic is about unifying the deployment experience between the SaaS and Self-Managed product contexts.

In SaaS, deployments are easy from Web Modeler. Users select a cluster and deploy. We want to bring the same experience also to Self-Managed (currently users fill out a manual entry form where they have to enter the cluster details including the credentials).

This change is relevant for the authorization slice of the epic where we will switch to using the user token instead of the M2M token generated using client ID and secret.

In short, it's about changing from this:
image
to this:
image

PS: I was planning to reach out to you today. I just wanted to try this out first to verify if it works. I will read the contribution guide and improve the PR, add tests, fill more details, etc. before marking it as ready. In the meantime, if you already find any red flags or possible improvements in the approach, please share.

Copy link
Member

@jwulf jwulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jwulf jwulf merged commit c427878 into alpha Nov 14, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants