feat(advisor): merge final review notes without recursive reviews - #12387
olegpulatov wants to merge 2 commits into
Conversation
c55e5c1 to
dca0f9d
Compare
|
One note from reading the final-boundary flow (no action needed if intentional): The Since the old comment on that |
eb68983 to
7e3959e
Compare
Configure eligible review intervals and opt-in final-yield reviews. Support inherited or explicit per-advisor catch-up, including cancellable strict waits, without gating pending advice delivery.
Batch accepted findings with ages and request at most one permitted continuation. Apply live delivery constraints at final boundaries, retain default plan preservation, and wake reviewers only on genuine user input.
7e3959e to
ae56d60
Compare
yes, thats exactly current default omp behaivour, - assistants which took too long will overfloat into later context. appreciate getting another pair of eyes on the code. |
What
I improved control for final review flow.
Why
Final reviews can arrive after work finishes. This keeps those findings visible and actionable without creating repeated review-continuation loops.
Depends on #12385. GitHub requires an upstream branch as the base for cross-fork PRs, so this draft targets
main; review its final-flow commit after #12385.Testing
bun test packages/coding-agent/test/advisor/ packages/coding-agent/test/advisor-tool-call-loop-guard.test.ts packages/coding-agent/test/agent-session-advisor-suppression.test.ts packages/tui/test/advisor-config.test.ts— 323 passedbun test packages/coding-agent/test/agent-session-advisor-terminal-unwind.test.ts packages/coding-agent/test/advisor-context-maintenance.test.ts— 29 passedbun check— passedbun checkpasses