Skip to content

fix(tui): retire finished rows before viewport drop under pinned frontier - #12646

Open
F0Rextasy wants to merge 1 commit into
can1357:mainfrom
F0Rextasy:fix/12584-pinned-frontier-drop-loss
Open

F0Rextasy wants to merge 1 commit into
can1357:mainfrom
F0Rextasy:fix/12584-pinned-frontier-drop-loss

Conversation

@F0Rextasy

Copy link
Copy Markdown

What

I reviewed the full diff; overflow rows clipped off the live viewport vanished without ever reaching native scrollback while a Task block pinned retirement, so the viewport now synchronously retires finished head rows before applying the drop slice.

Why

Fixes #12584

Testing

  • bun test packages/tui/test/transcript-container.test.ts (32 pass, 1 new: finished head retires before pinned-frontier clip)
  • bun --cwd=packages/tui run check:types (pass)
  • oxlint + oxfmt on both changed files (pass)

  • bun check passes
  • Tested locally
  • CHANGELOG updated with the required attribution (if user-facing; internal issue fixes use issue links, external contributions add the PR link and contributor credit after creation)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Live Task block pins transcript retirement; overflow drop clips uncommitted assistant rows (scrollback loss)

1 participant