Skip to content

fix(lsp): identify the target checkout in cross-worktree locations - #12647

Open
F0Rextasy wants to merge 1 commit into
can1357:mainfrom
F0Rextasy:fix/12569-lsp-cross-worktree-path
Open

F0Rextasy wants to merge 1 commit into
can1357:mainfrom
F0Rextasy:fix/12569-lsp-cross-worktree-path

Conversation

@F0Rextasy

Copy link
Copy Markdown
Contributor

What

I reviewed the full diff; definition results in sibling checkouts rendered identically to local files, so locations outside the session cwd now carry an explicit checkout suffix alongside the absolute path.

Why

Fixes #12569

Testing

  • bun test packages/coding-agent/test/tools/lsp-regressions.test.ts -t cross-worktree (1 pass, 4 assertions: suffix present for sibling, absent for local, context reads the right file)
  • bun --cwd=packages/coding-agent run check:types (pass)
  • oxlint + oxfmt on all 3 changed files (pass)

  • bun check passes
  • Tested locally
  • CHANGELOG updated with the required attribution (if user-facing; internal issue fixes use issue links, external contributions add the PR link and contributor credit after creation)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSP definition output hides the target checkout in cross-worktree lookups

1 participant