Skip to content

fix(memory): stop empty phase2 from wiping consolidated artifacts - #12650

Open
F0Rextasy wants to merge 1 commit into
can1357:mainfrom
F0Rextasy:fix/12596-memory-empty-phase2-wipe-guard
Open

F0Rextasy wants to merge 1 commit into
can1357:mainfrom
F0Rextasy:fix/12596-memory-empty-phase2-wipe-guard

Conversation

@F0Rextasy

Copy link
Copy Markdown

What

I reviewed the full diff; every empty Phase 2 run deleted MEMORY.md, memory_summary.md, and skills even when live consolidations existed, so the empty-input path now advances its watermark without touching on-disk artifacts.

Why

Fixes #12596 (data-loss half; the case-variant scope-key half stays open for a follow-up)

Testing

  • bun test packages/coding-agent/test/memories-runtime.test.ts (8 pass, 1 updated: empty Phase 2 preserves MEMORY.md/summary/skills)
  • bun --cwd=packages/coding-agent run check:types (pass)
  • oxlint + oxfmt on both changed files (pass)

  • bun check passes
  • Tested locally
  • CHANGELOG updated with the required attribution (if user-facing; internal issue fixes use issue links, external contributions add the PR link and contributor credit after creation)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

local memory (Windows): case-sensitive per-cwd scope keys strand consolidation; empty-scope Phase 2 can wipe shared artifacts

1 participant