feat(tui): add popups for prompt autocomplete triggers - #12671
Open
DarkPhilosophy wants to merge 1 commit into
Open
DarkPhilosophy wants to merge 1 commit into
DarkPhilosophy wants to merge 1 commit into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Add the passive popup renderer plus opt-in slash-command, file mention, prompt action/reference, and emoji popup placement in one self-contained change based directly on upstream/main. Model mentions remain in the dedicated inline model picker PR.
DarkPhilosophy
force-pushed
the
feat/autocomplete-popup-overlays-stacked
branch
from
September 21, 2026 08:27
ba687fa to
e8a2fa7
Compare
DarkPhilosophy
marked this pull request as draft
September 21, 2026 08:27
DarkPhilosophy
marked this pull request as ready for review
September 21, 2026 08:34
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
We missed the
^,@, and#triggers, and possibly one more, so these autocomplete commands need a separate PR.This PR is now a self-contained, single-commit change based directly on the latest
upstream/main. It does not contain the fork branch history.It adds the passive cursor-adjacent popup renderer and opt-in settings for:
@file and directory mentions;#prompt actions and GitHub references;:emoji suggestions.The missing fourth trigger was
:. The^model picker remains in the dedicated inline model picker PR (#11958), which has its own model-search UI and behavior.Why
Autocomplete lists normally allocate layout rows below the editor. Opening or filtering them moves the editor and chat, and can disturb native terminal scrolling. The passive popup renderer paints suggestions over the existing frame without allocating transcript rows or taking focus.
The non-command popup gate is restricted to explicit
@,#, and:prefixes. Bare or absolute path completion remains inline. Command arguments remain controlled independently bydisplay.commandSuggestionsPopup.Testing
bun test packages/coding-agent/test/command-suggestions-popup.test.ts- 12 pass, 0 fail.bun run --cwd packages/tui check:types- passed.bun run --cwd packages/coding-agent check:types- passed.bun run check:tools- passed.@file mentions,#prompt actions, and:emoji. It verifies that the bordered popup stays above the editor, below-editor content remains below it, and native history does not move.bun checkpasses