Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
roboomp
left a comment
roboomp
left a comment
There was a problem hiding this comment.
P1 — scoped two-line clarification, but the Cost heading currently calls provider-reported premium/credit meters OMP estimates.
Required packages/coding-agent changelog attribution is also missing.
Maintainer question: #12619 is broader than /session; should this partial clarification close it?
Thanks @F0Rextasy.
|
|
||
| if (stats.cost > 0 || normalizedPremiumRequests > 0 || stats.credits !== undefined) { | ||
| info += `\n${theme.bold("Cost")}\n`; | ||
| info += `\n${theme.bold("Cost (OMP estimate, not an invoice)")}\n`; |
There was a problem hiding this comment.
blocking: This heading also scopes the Premium Requests, Credits, Committed Credits, and Committed ACU rows below it. Those are not OMP estimates: Usage.credits is explicitly provider-reported (packages/catalog/src/types.ts:173), and premiumRequests is the Copilot counter. Calling the whole section an OMP estimate makes provider meters look locally calculated, which reverses the distinction this change is meant to add. Please qualify only stats.cost as estimated, or split the provider-reported meters into their own section.
| info += `${theme.fg("dim", "Append-Only:")} ${activeLabel} (setting: ${settingLabel})\n`; | ||
| } | ||
| info += `${theme.bold("Tokens")}\n`; | ||
| info += `${theme.bold("Tokens (local session accounting, not provider billing)")}\n`; |
There was a problem hiding this comment.
should-fix: This changes user-facing TUI copy in packages/coding-agent, but this PR has no packages/coding-agent/CHANGELOG.md entry and its changelog checklist remains unchecked. Repository convention requires an entry under ## [Unreleased]; for this external contribution, include the PR link and @F0Rextasy attribution.
2 participants
What
I reviewed the full diff; the session info panel presented local token totals and catalog-based cost next to each other with no scope, so both headers now state they are local accounting and estimates rather than provider billing.
Why
Fixes #12619
Testing
bun checkpasses