Upgrade click dependency
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This gh rule will need updating as this will never be executed |
tacrocha
previously approved these changes
May 1, 2024
MarcAndre-Rivet
commented
May 2, 2024
| @@ -12,13 +12,13 @@ authors = [ | |||
| license = "MIT" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.6" | |||
| python = ">=3.7,<3.12" | |||
There was a problem hiding this comment.
Updating click drops py3.6 support. The project also doesn't work with py3.12 as per test run as-is, hence the updated version range. We can always revisit as necessary.
MarcAndre-Rivet
commented
May 2, 2024
| { "os": "ubuntu-latest", "python": "3.8" }, | ||
| { "os": "ubuntu-latest", "python": "3.9" }, | ||
| { "os": "ubuntu-latest", "python": "3.10" }, | ||
| { "os": "ubuntu-latest", "python": "3.11" }, |
There was a problem hiding this comment.
testing the full range of versions supported
MarcAndre-Rivet
changed the title
click dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
clickdependency.celery>=5.3to continue using this project, as Celery>=5.3 requiresclick>=8.1.2/ causing an incompatible version matchup in Poetrypytestas well