-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: silence "LOAD segment with RWX permissions" warning #167
base: master
Are you sure you want to change the base?
cmake: silence "LOAD segment with RWX permissions" warning #167
Conversation
@fenugrec my compiler doesn't support |
Debian stable ("bullseye") uses cmake-3.18, Debian oldstable ("buster") is still on cmake-3.13, but "buster-backports" has cmake-3.18, too. |
I think bumping required to 3.18 is reasonable; distros with really old cmake have a simple workaround of just reverting this commit. |
Oops, actual test doesn't quite work as is, two issues - cmake invokes gcc for the link step, so the arg needs to be
We're also getting those super annoying warnings about |
2141cec
to
31ce5dc
Compare
Thanks for testing! Fixed the first issue, add missing I see a
but it correctly detects support for
|
Thanks, youǜve fixed the passing-wrong-arg problem, but since the test compilation fails, cmake still thinks the flag is "not supported" |
Just noticed, too. But why does it say |
AFAIK because https://cmake.org/cmake/help/latest/module/CheckLinkerFlag.html
|
31ce5dc
to
750452e
Compare
Fixes: 89c44fe ("correct LED initialization for canable interfaces")
This way uncrustify produces better indention.
This way uncrustify produces better indention.
This increases the size of the binary in a stm32f072 a bit: before: Memory region Used Size Region Size %age Used FLASH: 17296 B 128 KB 13.20% RAM: 4268 B 16 KB 26.05% after: Memory region Used Size Region Size %age Used FLASH: 17312 B 128 KB 13.21% RAM: 4268 B 16 KB 26.05% Closes: candle-usb#164
750452e
to
62141db
Compare
This is the default for yml files for the github workflows.
Use containers to build on various Debian based distributions: - Ubuntu: 20.04 - Ubuntu: 22.04 - Ubuntu: 24.04 - Ubuntu: rolling - Debian: oldstable - Debian: stable - Debian: testing - Debian: unstable
62141db
to
19d7a76
Compare
Link: #106