fix: correct import in fiveg_f1 schema #268
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
fiveg_f1/v0schema to importconlistfrompydanticinstead of trying to import it fromtyping(where it is not available).I noticed this error when running
interface_tester discover.The discover interfaces job in CI runs Pydantic 1, and the schema uses the Pydantic 2 argument for
conlist(2 usesmin_length, 1 usesmin_items), so this fix causes the CI job to fail.It seems like a regression to port this to Pydantic 1 (though very easy), but running Pydantic 2 in CI doesn't seem to be an option right now as that would cause other schemas to error.
I guess it passed before because
interface_testerlogs import errors and exits with success, but exits with failure on type errors, but I haven't looked into it.