Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto promote to beta when tests pass #81

Merged
merged 14 commits into from
Oct 4, 2024

Conversation

jpm-canonical
Copy link
Contributor

@jpm-canonical jpm-canonical commented Sep 30, 2024

Summary

Add workflow to build, publish, test and promote snap. This is done weekly, but also on any commit and PR to the main branch. A matrix is used to build and test on arm64 and amd64.

This PR does not solve a possible race condition that can occur (canonical/matter-pi-gpio-commander#83).

Related issues

Testing steps

Successful run: https://github.com/canonical/chip-tool-snap/actions/runs/11105153111

@jpm-canonical jpm-canonical marked this pull request as ready for review September 30, 2024 12:45
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simplification. I've just commented on a few minor issues.

.github/workflows/snap-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/snap-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/snap-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/snap-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/snap-ci.yaml Show resolved Hide resolved
.github/workflows/snap-ci.yaml Outdated Show resolved Hide resolved
@jpm-canonical
Copy link
Contributor Author

The tests are now using the local snap:

snap.go:42: [exec] sudo snap install --dangerous ../chip-tool_27b5f3ab+snap_amd64.snap
snap.go:42: [exec] sudo snap install --dangerous ../chip-tool_27b5f3ab+snap_arm64.snap

@jpm-canonical jpm-canonical merged commit 13d9331 into main Oct 4, 2024
4 checks passed
@jpm-canonical jpm-canonical deleted the IENG-1170-workflow-publish-promote branch October 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants