-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: update description #165
base: main
Are you sure you want to change the base?
Conversation
Resolves canonical#164.
version Show version details | ||
|
||
Action (make things happen): | ||
cut Cut a tree with selected slices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cut Cut a tree with selected slices | |
cut Cut a package with selected slices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK "cut a tree with selected slices" is what is currently printed when you run chisel help --all
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it's copied from the help. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the question of whether we want to change the description of the commands or add more information. In my opinion, that can wait until next cycle where we will have a focus on documentation. For now it seems like an easy win to update the snap to contain the same information that the CLI has.
Thanks Rafid for this UX improvements!
@@ -12,11 +12,16 @@ description: | | |||
|
|||
Commands can be classified as follows: | |||
|
|||
Basic: help, version | |||
Action: cut | |||
Basic (general operations): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this information in the snap description at all? This is not conventional for snaps or packages in general. I suggest doing the usual and stopping at line 10 above.
Resolves #164.
Updates the snap description. Uses the output from
chisel help --all
instead ofchisel --help
for details.