chore: promote snap to candidate on release #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promote snap to latest/candidate channels upon every GitHub release.
rebornplusplus
force-pushed
the
ROCKS-747/promote-snap
branch
from
bdab19f
to
e873286
Compare
cjdcordeiro
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Cool, thanks.
Seems to follow the same approach as https://github.com/canonical/pebble/pull/255/files, so it LGTM
As for the new secret, either @jnsgruk or @niemeyer need to add it.
Double-quotes are not okay in a Github workflow expressions. Change back to single-quotes.
|
Okay, that's done. I'll merge this now. Thanks all! |
rebornplusplus
added a commit
to rebornplusplus/chisel
that referenced
this pull request
Aug 25, 2023
In canonical#94, the workflow for promoting snaps from latest/edge to latest/candidate upon GitHub release, was introduced. We didn't have riscv64 builds for the snap back then. We have it now. [1] This commit extends the promotion workflow for the riscv64 architecture. References: - [1] https://answers.launchpad.net/launchpad/+question/707699
rebornplusplus
added a commit
to rebornplusplus/chisel
that referenced
this pull request
Aug 25, 2023
In canonical#94, the workflow for promoting snaps from latest/edge to latest/candidate upon GitHub release was introduced. We didn't have riscv64 builds for the snap back then. We have it now. [1] This commit extends the promotion workflow for the riscv64 architecture. References: - [1] https://answers.launchpad.net/launchpad/+question/707699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote snap to
latest/candidatechannels upon every GitHub release.Successfully executing this workflow job would require adding a
SNAPCRAFT_STORE_CREDENTIALSsecret in this repo. Please let me or @cjdcordeiro know if you don't have access to it (it's inside the credentials for the bot account).Similar to canonical/pebble#255.
Demo run: https://github.com/rebornplusplus/chisel/actions/runs/5925313450
(not exactly the same behaviour as the demo promoted to
latest/betaand ran the workflow job onpush)