Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation #1

Merged
merged 7 commits into from
May 2, 2023
Merged

Initial implementation #1

merged 7 commits into from
May 2, 2023

Conversation

ghislainbourgeois
Copy link
Collaborator

Description

Initial implementation of the httpreq provider for ACME.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

github-advanced-security[bot]
github-advanced-security bot found potential problems May 2, 2023
View reviewed changes
lib/charms/tls_certificates_interface/v1/tls_certificates.py
provider_relation_data = _load_relation_data(event.relation.data[self.charm.app])
if not self._relation_data_is_valid(requirer_relation_data):
logger.warning(
f"Relation data did not pass JSON Schema validation: {requirer_relation_data}"

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (certificate)](1) as clear text.
Gmerold
Gmerold suggested changes May 2, 2023
View reviewed changes
.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/promote.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
Gmerold
Gmerold approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghislainbourgeois ghislainbourgeois merged commit 5294a5d into main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gmerold Gmerold Gmerold approved these changes

@gruyaume gruyaume Awaiting requested review from gruyaume

@saltiyazan saltiyazan Awaiting requested review from saltiyazan

@sanchezfdezjavier sanchezfdezjavier Awaiting requested review from sanchezfdezjavier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghislainbourgeois @Gmerold