Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uses charming actions workflow to publish the charm #15

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

gruyaume
Copy link
Contributor

@gruyaume gruyaume commented Nov 16, 2023

Description

The current github releases did not match the actual charmhub releases because we were not using the Charming Actions workflow. This made it so that the charm engineering releases page showed this charm as being 18 commits behind (picture below). This PR makes it so that we use this workflow, making it identical to the other ACME operators github CI.
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gruyaume gruyaume requested a review from a team as a code owner November 16, 2023 18:10
.github/workflows/main.yaml Show resolved Hide resolved
.github/workflows/main.yaml Show resolved Hide resolved
@gruyaume gruyaume requested a review from a team as a code owner November 20, 2023 16:00
@gruyaume gruyaume requested a review from gatici November 20, 2023 16:01
@gruyaume gruyaume merged commit c48de82 into main Nov 20, 2023
8 checks passed
@gruyaume gruyaume deleted the dev-ci branch November 20, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants