Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update acme_client library to fix blocking bug #2

Merged
merged 2 commits into from
May 18, 2023
Merged

Update acme_client library to fix blocking bug #2

merged 2 commits into from
May 18, 2023

Conversation

ghislainbourgeois
Copy link
Collaborator

Description

Update acme_client library to fix blocking bug

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@ghislainbourgeois ghislainbourgeois requested a review from a team May 18, 2023 17:57
gruyaume
gruyaume approved these changes May 18, 2023
View reviewed changes
.github/workflows/main.yaml Show resolved Hide resolved
@ghislainbourgeois ghislainbourgeois merged commit 5212b9e into main May 18, 2023
7 checks passed
@ghislainbourgeois ghislainbourgeois deleted the update-lib branch May 18, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghislainbourgeois @gruyaume