chore(controllers): Do not run controlplane specific controllers on workers #1738
+76
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HomayoonAlimohammadi
force-pushed
the
KU-3933/separate-controllers
branch
from
fd02061 to
705a40d
Compare
HomayoonAlimohammadi
changed the title
…rkers Signed-off-by: Homayoon (Hue) Alimohammadi <[email protected]>
HomayoonAlimohammadi
force-pushed
the
KU-3933/separate-controllers
branch
from
705a40d to
531079c
Compare
|
@HomayoonAlimohammadi should we really backport this? I understand that this is not really a bugfix but just a cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR prevents control plane specific controllers from running on workers. The coordinator is refactored a bit to better separate controller options as well.