fix: Fix Invalid iproute2 JSON output in arm64
#1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
reviewed
Sep 3, 2025
mateoflorido
force-pushed
the
m/fix-invalid-vlan-vin
branch
from
00cea61 to
05b4ca3
Compare
|
@mateoflorido Thanks a lot for the workaround and LGTM. I think this can catch what we've seen so far. Even if it doesn't catch every edge case, a valid json value cannot start with a number and continue with a string, so it should be quite benign for any valid response and shouldn't do any harm. I'll leave the final approval to @addyess and @berkayoz |
mateoflorido
force-pushed
the
m/fix-invalid-vlan-vin
branch
from
1a55d26 to
01c344f
Compare
mateoflorido
force-pushed
the
m/fix-invalid-vlan-vin
branch
from
01c344f to
ad6254d
Compare
addyess
reviewed
Sep 3, 2025
Comment on lines
+36
to
+37
| // combines the VXLAN VNI value with the fan-map extension, resulting in | ||
| // invalid JSON, but a valid YAML. |
addyess
approved these changes
Sep 3, 2025
mateoflorido
added
backport
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Fix Invalid `iproute2` JSON output in arm64 (cherry picked from commit adbd67e)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Fix Invalid `iproute2` JSON output in arm64 (cherry picked from commit adbd67e)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Fix Invalid `iproute2` JSON output in arm64 (cherry picked from commit adbd67e)
|
Successfully created backport PR for |
mateoflorido
added a commit
that referenced
this pull request
Sep 4, 2025
Fix Invalid `iproute2` JSON output in arm64 (cherry picked from commit adbd67e) Co-authored-by: Mateo Florido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an invalid
iproute2JSON output in arm64Solution
Given that all JSON is a valid YAML we can use its parser to avoid errors caused by invalid JSON.
Issue
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2121908
Backport
Should this PR be backported? If so, to which release?
Checklist
type: title