-
Notifications
You must be signed in to change notification settings - Fork 32
docs: add charm patch notices #1826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add charm patch notices #1826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but the tests are failing.
The CI is failing due to the linkchecker. I have investigated the issue and the CI needs further work. As a temporary work around, I have manually tested the links that failed the test and verified they are still up to date. I am going to merge the PR as the error is not a true blocker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
* Add patch notices for 1.32 charm * spellcheck fixes * remove commented out sections * Reword one entry for accuracy (cherry picked from commit 09b1405)
Successfully created backport PR for |
Successfully created backport PR for |
* Add patch notices for 1.32 charm * spellcheck fixes * remove commented out sections * Reword one entry for accuracy (cherry picked from commit 09b1405)
* Add patch notices for 1.32 charm * spellcheck fixes * remove commented out sections * Reword one entry for accuracy (cherry picked from commit 09b1405)
Successfully created backport PR for |
* Add patch notices for 1.32 charm * spellcheck fixes * remove commented out sections * Reword one entry for accuracy (cherry picked from commit 09b1405) Co-authored-by: Niamh Hennigan <[email protected]>
* Add patch notices for 1.32 charm * spellcheck fixes * remove commented out sections * Reword one entry for accuracy (cherry picked from commit 09b1405) Co-authored-by: Niamh Hennigan <[email protected]>
* Add patch notices for 1.32 charm * spellcheck fixes * remove commented out sections * Reword one entry for accuracy (cherry picked from commit 09b1405) Co-authored-by: Niamh Hennigan <[email protected]>
Description
We have no automation or change log so we must add our patch notices manually
Solution
Adding patch notices for the 1.32 charm
Issue
N/A
Backport
1.32, 1.33, 1.34
Checklist
type: title
If any item on the checklist is not complete, please provide justification why.