Skip to content

Conversation

nhennigan
Copy link
Contributor

@nhennigan nhennigan commented Sep 5, 2025

Description

We have no automation or change log so we must add our patch notices manually

Solution

Adding patch notices for the 1.32 charm

Issue

N/A

Backport

1.32, 1.33, 1.34

Checklist

  • PR title formatted as type: title
  • Covered by unit tests
  • Covered by integration tests
  • Documentation updated
  • CLA signed
  • Backport label added if necessary

If any item on the checklist is not complete, please provide justification why.

Copy link
Member

@ktsakalozos ktsakalozos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but the tests are failing.

@nhennigan
Copy link
Contributor Author

The CI is failing due to the linkchecker. I have investigated the issue and the CI needs further work. As a temporary work around, I have manually tested the links that failed the test and verified they are still up to date. I am going to merge the PR as the error is not a true blocker.

@ktsakalozos ktsakalozos self-requested a review September 12, 2025 15:04
Copy link
Member

@ktsakalozos ktsakalozos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@nhennigan nhennigan merged commit 09b1405 into canonical:main Sep 12, 2025
6 of 10 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 12, 2025
* Add patch notices for 1.32 charm

* spellcheck fixes

* remove commented out sections

* Reword one entry for accuracy

(cherry picked from commit 09b1405)
@cdkbot
Copy link
Collaborator

cdkbot commented Sep 12, 2025

Successfully created backport PR for release-1.32:

@cdkbot
Copy link
Collaborator

cdkbot commented Sep 12, 2025

Successfully created backport PR for release-1.33:

github-actions bot pushed a commit that referenced this pull request Sep 12, 2025
* Add patch notices for 1.32 charm

* spellcheck fixes

* remove commented out sections

* Reword one entry for accuracy

(cherry picked from commit 09b1405)
github-actions bot pushed a commit that referenced this pull request Sep 12, 2025
* Add patch notices for 1.32 charm

* spellcheck fixes

* remove commented out sections

* Reword one entry for accuracy

(cherry picked from commit 09b1405)
@cdkbot
Copy link
Collaborator

cdkbot commented Sep 12, 2025

Successfully created backport PR for release-1.34:

nhennigan added a commit that referenced this pull request Sep 13, 2025
* Add patch notices for 1.32 charm

* spellcheck fixes

* remove commented out sections

* Reword one entry for accuracy

(cherry picked from commit 09b1405)

Co-authored-by: Niamh Hennigan <[email protected]>
nhennigan added a commit that referenced this pull request Sep 13, 2025
* Add patch notices for 1.32 charm

* spellcheck fixes

* remove commented out sections

* Reword one entry for accuracy

(cherry picked from commit 09b1405)

Co-authored-by: Niamh Hennigan <[email protected]>
nhennigan added a commit that referenced this pull request Sep 13, 2025
* Add patch notices for 1.32 charm

* spellcheck fixes

* remove commented out sections

* Reword one entry for accuracy

(cherry picked from commit 09b1405)

Co-authored-by: Niamh Hennigan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants