Fix locals packages list#617
Merged
Merged
Conversation
gesquivelgaghi
force-pushed
the
locals-packages-list
branch
from
6ba90bb to
c6b109d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the local repository package list deterministic by sorting package names before pagination, with additional Prettier-only formatting updates in unrelated files.
Changes:
- Sort local repository package names before displaying/paginating them.
- Add a patch changeset for the package list ordering fix.
- Apply Prettier formatting to saved-search and DonutChart test files.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/features/local-repositories/components/LocalRepositoryPackagesList/LocalRepositoryPackagesList.tsx |
Sorts package names before pagination. |
.changeset/all-pandas-hide.md |
Adds patch release note for the package list ordering fix. |
src/features/saved-searches/components/SearchBoxWithSavedSearches/SearchBoxWithSavedSearches.tsx |
Formatting-only change. |
src/features/saved-searches/components/SavedSearchList/SavedSearchList.tsx |
Formatting-only change. |
src/features/overview/components/DonutChart/DonutChart.test.tsx |
Formatting-only change. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
💰 |
gesquivelgaghi
force-pushed
the
locals-packages-list
branch
from
e50b096 to
ea01184
Compare
Contributor
TICS Quality Gate❌ Failedlandscape-ui
❌ Condition “No new Coding Standard Violations for level 1, 2, 3 with respect to Previous analysis” failed 3 times.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sort packages list so the order stays consistent across non-deterministic responses. Also ran
prettierwhich caused other file changesRelease Impact
Pick the target branch (see RELEASES.md for the full model):
dev— internal testing → publishes toppa-build-devmain— next beta → publishes toppa-buildrelease/YY.MM— point release on a maintained cycle → publishes toppa-build-YY.MM(and toppa-build-stableif this is the currently-promoted branch). Specify cycle:release/____Change type (tick one):
Checklist
pnpm changeset(orpnpm changeset --emptyif no CHANGELOG line is warranted) and committed the resulting.mdfile. Required for PRs targetingmainandrelease/*; enforced by theChangeset checkworkflow.scripts/).Versioning Reminder
Important
Landscape UI uses CalVer (
YY.MM.Point.Build). Version derivation by branch:main/point/*→YY.MM.0.<run>-betadev→YY.MM.0.<run>-devrelease/YY.MM→YY.MM.1.<run>(cycle pinned by branch name)