Chore: Remove duplicated api calls in mirrors

.changeset/lucky-donkeys-kneel.md

@@ -0,0 +1,2 @@
+---
+---

src/features/local-repositories/components/LocalRepositoriesList/LocalRepositoriesList.tsx

@@ -9,7 +9,7 @@ import usePageParams from "@/hooks/usePageParams";
 import { TablePagination } from "@/components/layout/TablePagination";
 import LocalRepositoriesListActions from "./components/LocalRepositoriesListActions";
 import LocalRepositoryPackagesCount from "./components/LocalRepositoryPackagesCount";
-import LocalRepositoryPublicationsCount from "./components/LocalRepositoryPublicationsCount";
+import { AssociatedPublicationsCount } from "@/features/publications";
 
 interface LocalRepositoriesListProps {
   readonly repositories: Local[];
@@ -60,7 +60,7 @@ const LocalRepositoriesList: FC<LocalRepositoriesListProps> = ({
       {
         Header: "Publications",
         Cell: ({ row: { original: repository } }: CellProps<Local>) => (
-          <LocalRepositoryPublicationsCount repository={repository} />
+          <AssociatedPublicationsCount sourceName={repository.name ?? ""} />
         ),
       },
       {

src/features/local-repositories/components/RemoveLocalRepositoryModal/RemoveLocalRepositoryModal.tsx

@@ -44,7 +44,6 @@ const RemoveLocalRepositoryModal: FC<RemoveLocalRepositoryModalProps> = ({
         openInNewTab
         showSources={false}
       />
-      <br />
       <p>
         After removal you won&apos;t be able to update any of these
         publications, but they will continue to be available.{" "}

src/features/mirrors/api/index.ts

@@ -1,6 +1,5 @@
 export * from "./useListMirrors";
 export * from "./useListMirrorPackages";
-export * from "./useListPublications";
 export * from "./useDeleteMirror";
 export * from "./useUpdateMirror";
 export * from "./useSyncMirror";
@@ -9,4 +8,3 @@ export * from "./useGetUbuntuEsmInfo";
 export * from "./useCreateMirror";
 export * from "./useGetMirror";
 export * from "./useBatchGetMirrors";
-export * from "./useListPublicationTargets";

src/features/mirrors/components/MirrorActions/MirrorActions.tsx

@@ -4,8 +4,10 @@ import type { FC } from "react";
 import { useBoolean } from "usehooks-ts";
 import UpdateMirrorModal from "../UpdateMirrorModal";
 import RemoveMirrorModal from "../RemoveMirrorModal";
-import { useListPublications, useListPublicationTargets } from "../..";
-import { NoPublicationTargetsModal } from "@/features/publication-targets";
+import {
+  NoPublicationTargetsModal,
+  useGetPublicationTargets,
+} from "@/features/publication-targets";
 
 interface MirrorActionsProps {
   readonly mirrorDisplayName: string;
@@ -17,15 +19,8 @@ const MirrorActions: FC<MirrorActionsProps> = ({
   mirrorName,
 }) => {
   const { setPageParams, createPageParamsSetter } = usePageParams();
-
-  const { publicationTargets = [] } = useListPublicationTargets({
-    pageSize: 1000,
-  }).data.data;
-
-  const { publications = [] } = useListPublications({
-    filter: `source="${mirrorName}"`,
-    pageSize: 1000,
-  }).data.data;
+  const { publicationTargets, isGettingPublicationTargets } =
+    useGetPublicationTargets();
 
   const {
     value: isUpdateModalOpen,
@@ -44,7 +39,7 @@ const MirrorActions: FC<MirrorActionsProps> = ({
   } = useBoolean();
 
   const tryPublish = () => {
-    if (publicationTargets.length || publications.length) {
+    if (publicationTargets.length) {
       setPageParams({
         sidePath: ["publish"],
         name: mirrorName,
@@ -83,6 +78,7 @@ const MirrorActions: FC<MirrorActionsProps> = ({
             icon: "upload",
             label: "Publish",
             onClick: tryPublish,
+            disabled: isGettingPublicationTargets,
           },
         ]}
         destructiveActions={[

src/features/mirrors/components/MirrorDetails/MirrorDetails.tsx

@@ -10,7 +10,7 @@ import {
 } from "@canonical/react-components";
 import Blocks from "@/components/layout/Blocks";
 import InfoGrid from "@/components/layout/InfoGrid";
-import { useGetMirror, useListPublicationTargets } from "../../api";
+import { useGetMirror } from "../../api";
 import usePageParams from "@/hooks/usePageParams";
 import { getSourceType, shouldShowAuthentication } from "./helpers";
 import MirrorPackagesCount from "../MirrorPackagesCount";
@@ -23,7 +23,10 @@ import UpdateMirrorModal from "../UpdateMirrorModal";
 import { useBoolean } from "usehooks-ts";
 import RemoveMirrorModal from "../RemoveMirrorModal";
 import { boolToLabel } from "@/utils/output";
-import { NoPublicationTargetsModal } from "@/features/publication-targets";
+import {
+  NoPublicationTargetsModal,
+  useGetPublicationTargets,
+} from "@/features/publication-targets";
 import {
   AssociatedPublicationsList,
   useGetPublicationsBySource,
@@ -73,12 +76,11 @@ const MirrorDetails: FC = () => {
   const { publications, isGettingPublications } =
     useGetPublicationsBySource(name);
 
-  const { publicationTargets = [] } = useListPublicationTargets({
-    pageSize: 1000,
-  }).data.data;
+  const { publicationTargets, isGettingPublicationTargets } =
+    useGetPublicationTargets();
 
   const tryPublish = () => {
-    if (publicationTargets.length || publications.length) {
+    if (publicationTargets.length) {
       setPageParams({
         sidePath: [...sidePath, "publish"],
       });
@@ -173,6 +175,7 @@ const MirrorDetails: FC = () => {
             hasIcon
             className="p-segmented-control__button"
             onClick={tryPublish}
+            disabled={isGettingPublicationTargets}
           >
             <Icon name="upload" />
             <span>Publish</span>

src/features/mirrors/components/MirrorsList/MirrorsList.tsx

@@ -9,7 +9,6 @@ import moment from "moment";
 import { Suspense, useMemo, type FC } from "react";
 import type { CellProps, Column } from "react-table";
 import { LIST_ACTIONS_COLUMN_PROPS } from "@/components/layout/ListActions";
-import MirrorPublicationsLink from "../MirrorPublicationsLink";
 import NoData from "@/components/layout/NoData";
 import usePageParams from "@/hooks/usePageParams";
 import MirrorPackagesCount from "../MirrorPackagesCount";
@@ -21,6 +20,7 @@ import {
   getOperationStatusIcon,
 } from "@/features/operations";
 import { TablePagination } from "@/components/layout/TablePagination";
+import { AssociatedPublicationsCount } from "@/features/publications";
 
 interface MirrorsListProps {
   readonly mirrors: Mirror[];
@@ -115,9 +115,7 @@ const MirrorsList: FC<MirrorsListProps> = ({ mirrors, emptyMsg }) => {
         Header: "Publications",
         Cell: ({ row: { original: mirror } }: CellProps<Mirror>) =>
           mirror.name ? (
-            <Suspense fallback={<LoadingState inline />}>
-              <MirrorPublicationsLink mirrorName={mirror.name} />
-            </Suspense>
+            <AssociatedPublicationsCount sourceName={mirror.name} />
           ) : (
             <NoData />
           ),