feat: revert info icon in navigation to have dark theme color

Signed-off-by: Mason Hu <[email protected]>
canonical · Feb 22, 2024 · 642fcfe · 642fcfe
1 parent f081c77
commit 642fcfe
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 10 deletions.
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -22,8 +22,8 @@ const config: PlaywrightTestConfig<TestOptions> = {
   forbidOnly: !!process.env.CI,
   /* Retry on CI only */
   retries: process.env.CI ? 2 : 0,
-  /* Opt out of parallel tests. */
-  workers: 1,
+  /* Opt out of parallel tests on CI. */
+  workers: process.env.CI ? 1 : 3,
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
   reporter: process.env.CI ? "blob" : "html",
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */

diff --git a/src/components/HelpLink.tsx b/src/components/HelpLink.tsx
@@ -12,7 +12,7 @@ const HelpLink: FC<Props> = ({ children, href, title }) => {
     <div className="help-link">
       {children}
       <a href={href} target="_blank" rel="noreferrer" title={title}>
-        <Icon name="information" className="help-link-icon" />
+        <Icon name="info--dark" className="help-link-icon" />
       </a>
     </div>
   );

diff --git a/src/components/Navigation.tsx b/src/components/Navigation.tsx
@@ -275,8 +275,8 @@ const Navigation: FC = () => {
                       title="Documentation"
                     >
                       <Icon
-                        className="is-light p-side-navigation__icon"
-                        name="information"
+                        className="p-side-navigation__icon"
+                        name="info--light"
                       />{" "}
                       Documentation
                     </a>

diff --git a/src/components/forms/NetworkDevicesForm.tsx b/src/components/forms/NetworkDevicesForm.tsx
@@ -123,7 +123,7 @@ To change it, edit it in the profile or project it originates from,
 or remove the originating item"
                 position="btm-left"
               >
-                <Icon name="information" />
+                <Icon name="info--dark" />
               </Tooltip>
             ),
           });
@@ -168,7 +168,7 @@ or remove the originating item"
                 <>
                   custom network{" "}
                   <Tooltip message="A custom network can be viewed and edited only from the YAML configuration">
-                    <Icon name="information" />
+                    <Icon name="info--dark" />
                   </Tooltip>{" "}
                 </>
               ) : readOnly ? (

diff --git a/src/pages/instances/forms/CreateInstanceSnapshotForm.tsx b/src/pages/instances/forms/CreateInstanceSnapshotForm.tsx
@@ -137,7 +137,7 @@ const CreateInstanceSnapshotForm: FC<Props> = ({
                 message={statefulInfoMessage}
                 zIndex={TOOLTIP_OVER_MODAL_ZINDEX}
               >
-                <Icon name="information" />
+                <Icon name="info--dark" />
               </Tooltip>,
             ]
           : []),

diff --git a/src/pages/projects/forms/ProjectDetailsForm.tsx b/src/pages/projects/forms/ProjectDetailsForm.tsx
@@ -199,7 +199,7 @@ const ProjectDetailsForm: FC<Props> = ({ formik, project, isEdit }) => {
                       className="checkbox-label-tooltip"
                       message={`Allow profiles to enable custom${"\n"}restrictions on a project level`}
                     >
-                      <Icon name="information" />
+                      <Icon name="info--dark" />
                     </Tooltip>
                   </>
                 }
@@ -286,7 +286,7 @@ const ProjectDetailsForm: FC<Props> = ({ formik, project, isEdit }) => {
                   className="checkbox-label-tooltip"
                   message={`Custom restrictions are only available${"\n"}to projects with enabled profiles`}
                 >
-                  <Icon name="information" />
+                  <Icon name="info--dark" />
                 </Tooltip>
               </>
             }

diff --git a/src/sass/_pattern_icon.scss b/src/sass/_pattern_icon.scss
@@ -8,3 +8,13 @@
     @include lxdui-icon-sidebar-collapse;
   }
 }
+
+.p-icon--info--light {
+  @extend %icon;
+  @include vf-icon-info($colors--dark-theme--icon);
+}
+
+.p-icon--info--dark {
+  @extend %icon;
+  @include vf-icon-info($colors--light-theme--icon);
+}