-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume list and iso imports #318
Conversation
Demo starting at https://lxd-ui-318.demos.haus |
ba2729d
to
13ea259
Compare
51377f5
to
566c607
Compare
bb76cc2
to
96596db
Compare
890377d
to
6cf462d
Compare
Can you please add the expected QA steps? |
Added QA steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. I'm adding a few suggestions and ideas for improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes. I've left a few minor comments for further improvements, but it's already looking much better.
Some issues I found:
Therefore, let's try only showing the message about converting an ISO once the user has chosen a Windows ISO using the file picker. Then, we show the information about converting Windows images, and we tailor the distrobuilder command to reference the specific file path of the image that the user chose with the file picker. Note:
Note that eventually, images created from instance snapshots would live under "Custom", which is why I wouldn't name it "uploaded", or something like that
|
…eation feat(volume) add volume list to storages and delete volume action
Co-authored-by: Michele Lo Russo <[email protected]>
Co-authored-by: Michele Lo Russo <[email protected]>
…oving / using them
a2a5342
to
2adcfae
Compare
2adcfae
to
e3b5efb
Compare
Thank you for the design review @piperdeck
Please have another look and if it is good to go please remove the "design needed" label and add the "design +1" one. Or maybe there are more suggestions? As for the "upload custom image" modal, I'd iterate on it maybe in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good to me. The instance creation flow feels great!
… be more clear to the user
aca35ad
to
4d54cd2
Compare
… are finished creating
…ible accross projects
4d54cd2
to
6b5bb76
Compare
Done
QA Steps
snap refresh lxd --channel=latest/candidate
)