Add volume list and iso imports

[edlerd]

Done

• Add storage volume list
• Add import local file to custom volume
• Add list of images (cached and ISO)

QA Steps

• launch a new instance and upload a prepared ISO (this needs LXD 5.16 or later, upgrade with snap refresh lxd --channel=latest/candidate)
• use the iso image for a new instance
• ensure the instance is launched with a special message (linking to the console tab)
• ensure instance can't be started on creation directly
• check the storage detail page
• check the storage detail page volume tab
• ensure ISO can be deleted on the volume tab if it is not in use.
• check list of images
• try deleting / using a cached image and an iso image

[webteam-app]

Demo starting at https://lxd-ui-318.demos.haus

[lorumic]

Can you please add the expected QA steps?

[edlerd]

Added QA steps.

[lorumic]

This is a good start. I'm adding a few suggestions and ideas for improvements.

[lorumic]

Thanks for applying the changes. I've left a few minor comments for further improvements, but it's already looking much better.

[piperdeck]

Some issues I found:

1. As we discussed in our last sync, "ISOs" should be referred to as "images" in most parts of the interface, since LXD supports more types of images than just ISOs.

2. I think the instuctions for pre-processing Windows images should be more contextual. It doesn't make sense to show the message "Image must be prepared with distrobuilder" every time someone goes to upload an image. The user may well be uploading, for example, a linux image in qcow2 format.

Therefore, let's try only showing the message about converting an ISO once the user has chosen a Windows ISO using the file picker. Then, we show the information about converting Windows images, and we tailor the distrobuilder command to reference the specific file path of the image that the user chose with the file picker.

Note:

• distrobuilder does not, in fact, come with lxd. So the user should be directed to install it.
• There are a few other dependencies besides distrobuilder that need to be install also. These are outlined in Miona's tutorial.
• This is a complex design problem. I'll work on this and come up with a more robust design for how this should work.

3. The Images > Custom ISOs tab could probably use a rename (as noted above), since not all uploaded images will be ISOs. Perhaps:
   • Images
     • Cached
     • Custom

Note that eventually, images created from instance snapshots would live under "Custom", which is why I wouldn't name it "uploaded", or something like that

4. The Images page should also probably be a place from which to upload a new custom image.

5. When a windows instance is created, it's easy to miss the pop-up message explaining what to do. Maybe include a CTA button in the pop-up?

[edlerd]

Thank you for the design review @piperdeck
I realized all the suggestions you mentioned above, and also the additional ones we discussed today, including

• redesign the "select base image" button / "change image" buttons on instance launch
• after custom image upload the users goes back to the image list with the new images select button positive

Please have another look and if it is good to go please remove the "design needed" label and add the "design +1" one. Or maybe there are more suggestions? As for the "upload custom image" modal, I'd iterate on it maybe in a separate PR.

[piperdeck]

Everything seems good to me. The instance creation flow feels great!