Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid loading project when no project name is specified #354

Merged
merged 1 commit into from
May 24, 2023
Merged

Avoid loading project when no project name is specified #354

merged 1 commit into from
May 24, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented May 24, 2023

Done

  • Avoid loading project when no project name is specified

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described in the Readme.
  2. Perform the following QA steps:
    • check pages without a project have no requests for projects

@edlerd edlerd requested a review from lorumic May 24, 2023 15:46
@webteam-app
Copy link

Demo starting at https://lxd-ui-354.demos.haus

@edlerd edlerd merged commit 7e24a45 into canonical:main May 24, 2023
@edlerd edlerd deleted the fix-project branch June 7, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @lorumic