Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snapshot-form): Expiration time form field error when not touched WD-4163 #372

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix(snapshot-form): Expiration time form field error when not touched WD-4163 #372

merged 1 commit into from
Jun 7, 2023

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Jun 7, 2023 •
edited
Loading

Done

  • Previously, when manually creating a snapshot, users got an error in the “Expiry time” field as soon as entering the Expiry date.
  • The error now appear only if the user has touched with the field.

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described in the Readme.
  2. Perform the following QA steps:
    • [List the steps to QA the new feature(s) or prove that a bug has been resolved]

Screenshots

Before:
image
After:
image

@webteam-app
Copy link

Demo starting at https://lxd-ui-372.demos.haus

@aaryanporwal aaryanporwal requested a review from edlerd June 7, 2023 11:31
@aaryanporwal aaryanporwal changed the title fix(snapshot-form): Fix expiration time error when not touched WD-4163 fix(snapshot-form): Fix expiration time form field showing error when not touched WD-4163 Jun 7, 2023
@aaryanporwal aaryanporwal changed the title fix(snapshot-form): Fix expiration time form field showing error when not touched WD-4163 fix(snapshot-form): Fix expiration time form field error when not touched WD-4163 Jun 7, 2023
@aaryanporwal aaryanporwal changed the title fix(snapshot-form): Fix expiration time form field error when not touched WD-4163 fix(snapshot-form): Expiration time form field error when not touched WD-4163 Jun 7, 2023
edlerd
edlerd approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edlerd edlerd merged commit aa4efc9 into canonical:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaryanporwal @webteam-app @edlerd