Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loader): fix loading state on smaller devices WD-4197 #373

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix(loader): fix loading state on smaller devices WD-4197 #373

merged 1 commit into from
Jun 7, 2023

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Jun 7, 2023 •
edited
Loading

Done

  • [List of work items including drive-bys]

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described in the Readme.
  2. Perform the following QA steps:
    • [List the steps to QA the new feature(s) or prove that a bug has been resolved]

Screenshots

image

@webteam-app
Copy link

Demo starting at https://lxd-ui-373.demos.haus

@aaryanporwal aaryanporwal changed the title fix(loader): fix loading state on smaller devices fix(loader): fix loading state on smaller devices WD-4197 Jun 7, 2023
@edlerd edlerd merged commit ba93c34 into canonical:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaryanporwal @webteam-app @lorumic @edlerd