Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep items bottom-aligned when not authenticated #375

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Keep items bottom-aligned when not authenticated #375

merged 1 commit into from
Jun 8, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Jun 7, 2023

Done

  • Ensure that the 3 bottom links and the expand/collapse button in the side navigation are kept bottom-aligned when the user is not authenticated

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described in the Readme.
  2. Perform the following QA steps:
    • Remove trusted certificates to get the "unauthenticated" side navigation
    • Check that the items are kept at the bottom of the side navigation

@lorumic lorumic requested a review from edlerd June 7, 2023 21:15
@webteam-app
Copy link

Demo starting at https://lxd-ui-375.demos.haus

@edlerd edlerd merged commit 14846ba into canonical:main Jun 8, 2023
@lorumic lorumic deleted the fix-side-nav branch June 8, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorumic @webteam-app @edlerd