Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid navigation open/close on first paint, avoid closing menu on resize for mobile #376

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jun 8, 2023

Done

  • Avoid navigation open/close on first paint, avoid closing menu on resize for mobile (due to url bar hiding the resize is triggered while browsing the nav)

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described in the Readme.
  2. Perform the following QA steps:
    • test nav behaviour on large/medium/small devices

…nu on resize for mobile (due to url bar hiding the resize is triggered while browsing the nav)
@webteam-app
Copy link

Demo starting at https://lxd-ui-376.demos.haus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants