Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts for common keyboard combinations #381 #383

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jun 9, 2023

Done

  • add shortcuts to the console view of an instance

Fixes #381

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described in the Readme.
  2. Perform the following QA steps:
    • test keyboard shortcuts in console view

@webteam-app
Copy link

Demo starting at https://lxd-ui-383.demos.haus

@lorumic
Copy link
Contributor

lorumic commented Jun 9, 2023

There's a fundamental UX problem here: once you go "Fullscreen" - and you're likely to do that immediately on a Windows VM if you're using a medium/small res screen, since the mouse tracking is completely broken otherwise - you don't have access to the shortcuts anymore. Which means that each and every time you want to use one, you need to exit full screen, select the shortcut, and go full screen again.
What I have in mind is something similar to what TeamViewer does for example. In fullscreen mode, you move the pointer to the upper edge and an auto-hiding toolbar with controls appears. Would it be possible to do something like that here? Make some element overlay the spice wrapper - with CSS position - and making it visible only when the pointer is in some upper region of the full-screen window?
It can also be postponed if it takes too much time, and we want to release a quick fix.

Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above for a possible improvement. In general, the VGA console still has some major issues on low resolution screens - for Windows VMs at least.

@edlerd edlerd merged commit 18acc38 into canonical:main Jun 9, 2023
@edlerd edlerd deleted the add-console-shortcuts branch June 9, 2023 22:11
@edlerd
Copy link
Collaborator Author

edlerd commented Jun 9, 2023

The overlay is a good idea. Though hard to get right. Because it easily gets too often into the way if it shows to soon. Finding a good balance for it might take a bit bigger initiative. For now let's unblock the windows login.

@lorumic
Copy link
Contributor

lorumic commented Jun 9, 2023

Sure, sounds reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI should allow to pass "ctrl-alt-del" combination
3 participants