-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use config api for server settings WD-7389 instance defaults WD-7390 and project defaults #543
Conversation
Demo starting at https://lxd-ui-543.demos.haus |
53b5915
to
23f0a20
Compare
23f0a20
to
47d6740
Compare
7ec7d39
to
c244175
Compare
28bdc63
to
dcae3e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments, I'd feel more comfortable if someone else also have a review since I may not be the most familiar with the code yet
dcae3e0
to
c117b62
Compare
feat(instance) use config api for project defaults feat(instance) use config api for instance defaults WD-7390 feat(config) use config api for server settings WD-7389 Signed-off-by: David Edler <[email protected]>
c117b62
to
74200a6
Compare
Checked during QA:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a bunch of assignment shorthand suggestions (I recommend using the "Add suggestion to batch" button if you want to implement them, because they are a lot), and a few other questions/proposals for tiny improvements. Feel free to merge with or without these changes.
0c5eac8
to
606d202
Compare
Update src/pages/settings/Settings.tsx Co-authored-by: Michele Lo Russo <[email protected]> Signed-off-by: David Edler <[email protected]>
606d202
to
997d751
Compare
Done
Fixes WD-7389 WD-7390
QA